fix #1274: test for dotty bootstrap based on tasty #1427
Conversation
liufengyun
force-pushed
the
fix-i1274
branch
4 times, most recently
from
f87791f to
f6f28d8
Compare
|
I see what you're trying to do but this still seem like a very weird change to me, do we really want the scala bootclasspath to have a lesser priority than the scala user classpath? |
|
@smarter letting user to override the compiler runtime libs seems reasonable for following cases:
WDYT? BTW, the change passes the test set if run locally. I'm still investigating why it fails on Jenkins. |
|
Would be interesting to hear from someone with more experience with classfile resolving like @adriaanm maybe ? |
|
Finally passed all tests. Review @smarter ? |
|
Note that scalac will stop using the bootclasspath with Java 9 where it's not available anymore apparently: scala/scala@ce08ea5 |
liufengyun
force-pushed
the
fix-i1274
branch
2 times, most recently
from
0c1283a to
53b2ff9
Compare
| val noCheckOptions = List( | ||
| // "-verbose", | ||
| // "-Ylog:frontend", | ||
| // "-Xprompt", | ||
| // "-explaintypes", | ||
| // "-Yshow-suppressed-errors", | ||
| "-d", defaultOutputDir, | ||
| "-pagewidth", "160") |
There was a problem hiding this comment.
Note that I moved the -d option to noCheckOptions, so that the dotc_core_nocheck test case also generates class files under ./out/, instead of the current directory.
liufengyun
force-pushed
the
fix-i1274
branch
2 times, most recently
from
b25b020 to
5f0cec6
Compare
|
This is now rebased and test pass. |
Fix #1274.
The real change is to make user-supplied
-classpathtake precedence over libraries from the compiler runtime.